#464 Improve error message when program is missing arm of branching statement #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developedby
reviewed
Jul 25, 2024
src/lib.rs
Outdated
| @@ -197,6 +198,7 @@ pub fn readback_hvm_net( | |||
| let mut diags = Diagnostics::default(); | |||
| let net = hvm_to_net(net); | |||
| let mut term = net_to_term(&net, book, labels, linear, &mut diags); | |||
| #[allow(clippy::mutable_key_type)] | |||
There was a problem hiding this comment.
Did this start to flag after a clippy update?
There was a problem hiding this comment.
I think so, with rust 1.80
developedby
requested changes
Jul 25, 2024
developedby
requested changes
Jul 25, 2024
| @@ -14,6 +14,7 @@ use diagnostics::{Diagnostics, DiagnosticsConfig, ERR_INDENT_SIZE}; | |||
| use net::hvm_to_net::hvm_to_net; | |||
|
|
|||
| pub mod diagnostics; | |||
| #[allow(clippy::mutable_key_type)] | |||
There was a problem hiding this comment.
Add a comment explaining why this is necessary.
Eg. "Name is implemented with inner mutability so it triggers this warning, but we know it works."
developedby
approved these changes
Jul 25, 2024
imaqtkatt
deleted the
464-improve-error-message-when-program-is-missing-arm-of-branching-statement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.